WIP: Upgrade to latest electron #4354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2019
Closed
* use relative types path from sinon-chai * change sinon-chai path post-install
* add test that performance getEntries return arrays * add test for clock.restore, add custom lolex version * use lolex 4.1.0, with fix
* Add Google Cloud env vars to ci_providers check * Update snapshot on ci build warning to include googleCloud * updated unit tests to ensure commit defaults when undefined, null, or falsy
* actually require coffeescript. 😅 * allow commit message to build binary * test binary [build binary]
* rename s3 bucket for internal test runner assets * more renames * more renames * flatten internal assets Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* fix(deps): update fs-extra to 2.1.2 🌟 * rename `clobber` option to `overwrite` per https://github.com/jprichardson/node-fs-extra/pull/333/files Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* fix(deps): update is-fork-pr to 2.3.0 🌟 * add 'is-fork-pr' to renovate internal group Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
) * fix programmatic blur events, allow typing into currently focused, fix getHostContenteditable * intercept .blur * reference issues in tests * make tests account for conditional number of new lines inserted - newer browsers insert a double new line, whereas older browsers dont - write a helper that exposes the multiplier of new lines * cleanup, remove dead code * make tests dynamic when browser is or isn't out of focus * cleanup, remove old notes, add more notes * add failing tests for when native focus / blur are called multiple times - need to handle not firing the events conditionally based on whether or not the element would / should receive them * remove old code for priming focus/blur events when window is out of focus * remove dead code * update focus_blur spec + add chai-subset * decaffeinate: Rename focus_blur_spec.coffee from .coffee to .js * decaffeinate: Convert focus_blur_spec.coffee to JS * decaffeinate: Run post-processing cleanups on focus_blur_spec.coffee * add failing test * fix double blur/focus events * make document.hasFocus always return true, add test * fix focus events when non-focusable element * remove unneeded retrun * fix focusing body/ bluring active element on click * forgot to call .get() with index * fix focus issue with body/window * still allow firefocus on window, skip firing focus if firstfocusable is window during click * left out return in intercept blur/focus * cleanup test code for focus_blur spec * add tests to type_spec, focus_blur_spec 00-00005bfe * update focus logic for click, fix dtslint error 06-00003d9c * add tests for selectionchange event in focus_blur spec 01-00000dae * set dep to exact version 06-00002320 * minor formatting * intercept focus/blur for SVGElement * add comment to type-into-already-focused logic Co-authored-by: Brian Mann <brian.mann86@gmail.com> Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* add iframe to fixtures/dom as a test
* remove coveralls dep - not used anymore * remove trailing comma in package
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
…shot names (#4317) * Ensure that test titles are strings before sanitizing them for screenshot names * Fix linting errors * stringify non-string title, return '' for null and undefined * minor cleanup. extract to outer function. refactor to lodash. Co-authored-by: Brian Mann <brian.mann86@gmail.com>
…rror to send circular request bodies (#4407) * use a parser that supports circular json * update tests to work with new socketio version * add error message when users supply circular body to visit/request * show the path of the circular reference detected * Revert "use a parser that supports circular json" This reverts commit c052f44. * add failing driver and server tests for circular objs over websocket * use a parser that supports circular json * add has-binary2 patch that enables circular objects to be inspected * update socket spec * rejectUnauthorized: false * use @packages/socket instead of copying client source * prevent false positive * use commit hash for socket.io-circular-parser * cleanup bundling of socket.io for node + browser - keep the interfaces identical - browser simply has less properties than the node variant * properly import client + circularParser from socket package * @cypress/what-is-circular * dont require the extension, it causes gulp to hang * fix runner tests hanging Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* do not watch pluginsFile in run mode * add integration test ensuring watchers aren't applied in run mode Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* test that NO_PROXY is respected in agent * loosen up null check in agent * fix tests
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* don't take snapshots when numTestsKeptInMemory is 0 * set non-zero numTestsKeptInMemory for driver tests
…ng of socket package (#4469) * @cypress/what-is-circular@1.0.1 * bump socket.io-circular-parser to support circular refs in binary objs * add repro for nested request * use npx for patch-package since devDeps may not be available at build time * build on appveyor * keep patches in package * Revert "build on appveyor" This reverts commit e0d7672.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* chore(deps): Update https-proxy-agent to 2.2.0 🌟 * use rejectUnauthorized: false
* Update DEPLOY.md * Update DEPLOY.md
Co-authored-by: Renovate Bot <bot@renovateapp.com>
- Add a LOT more information into triaging issues - why we may close an issue, what to do when you are faced with common situations of people opening issues.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* Change dep of mocha-teamcity-reporter to be official release instead of cypress branch * Add regex replacement logic for 'duration='1234'' in teamcity reporter output * Add snapshot test for teamcity reporter * Add more reporteroptions to ensure no failures in tests
|
After this is merged, we should check the Mac build on Semaphore CI cypress-io/cypress-example-kitchensink#269 |
* temp 07/01/19 [skip ci] main lint files * use lint-staged scripts * fix all auto-fixable eslint errors * manually fix lint issues in files * temp 07/01/19 [skip ci] * bump eslint plugin versions, update circle.yml * [lint fix] remaining js files * update vscode/settings.json * add back stop-only * use stop-only for linting .onlys * fix verify_spec, build_spec * update json plugin * relint & apply corrections * fix appveyor.yml not cleansing env vars (very bad) * dont echo commit message in appveyor script * retry build & * re-add & upgrade lint-staged * update contributing docs * only let stop-only catch staged changes
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* chore(deps): Update mobx to 4.12.0 🌟 * update mobx-react packages to be compatible with mobx 4 * replace useStrict with new configure Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* refactor typedefs for cy * fix dtslint * fix dtslint * add test for extending types 03-00000014 * typo * docs and examples for cy type * sorted props * remove a few tabs * better jsdoc
* add e2e test that demonstrates encoding issue * fix all sorts of content-type wackiness, infer content-type from html * update snapshot * add kr, jp, cn tests * update snapshot * intercept any valid JS content-type * PR review changes
* Mention HTTP_PROXY if download error occurs; fall back to NPM's proxy config in install * better debug logs * snap-shot-it@7.7.1 -> 7.8.0 * respect npm_config in server, add debug logs for proxy
|
Closing for #4720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3568
We're upgrading Electron one major version in separate branches/PRs and then merging into this branch once tests are all passing. This PR should always pass. Once we get to the latest version of Electron, we'll merge into the v4.0 release branch.