-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): add 'no-force' rule #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be GREAT! We were just talking about this at a client I work for. With so many dev's we're trying to make changes to our Cypress setup and this would be a great deal of help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some changes for the copy of the rule description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, suggested adding a test
Looks like the readme also needs to be updated to reference this rule. |
Thanks for the suggestions, folks! |
do we want to warn for otherwise looks good. |
Hmm, good point. I don’t know though if we want it. Anyway it seems easy to add, should I? |
@kuzzaka sure, lets add it |
@bkucera done |
alright, I'm going to rename this to |
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@chrisbreiding It looks like |
oops |
I've submitted a fix here #45 |
…slint-8.23.1 chore(deps-dev): bump eslint from 8.23.0 to 8.23.1
Disallow usage of force option on inputs.