Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule): add 'no-force' rule #39

Merged
merged 2 commits into from
Feb 14, 2020
Merged

feat(rule): add 'no-force' rule #39

merged 2 commits into from
Feb 14, 2020

Conversation

kuzzaka
Copy link
Contributor

@kuzzaka kuzzaka commented Jan 30, 2020

Disallow usage of force option on inputs.

Copy link

@its-kyle-yo its-kyle-yo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be GREAT! We were just talking about this at a client I work for. With so many dev's we're trying to make changes to our Cypress setup and this would be a great deal of help!

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some changes for the copy of the rule description.

docs/rules/no-force-true.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, suggested adding a test

@abraham
Copy link

abraham commented Jan 31, 2020

Looks like the readme also needs to be updated to reference this rule.

@kuzzaka
Copy link
Contributor Author

kuzzaka commented Feb 12, 2020

Thanks for the suggestions, folks!

@kuceb
Copy link
Contributor

kuceb commented Feb 14, 2020

do we want to warn for trigger, check, rightclick, focus, select as well?

otherwise looks good.

@kuzzaka
Copy link
Contributor Author

kuzzaka commented Feb 14, 2020

Hmm, good point. I don’t know though if we want it. Anyway it seems easy to add, should I?

@kuceb
Copy link
Contributor

kuceb commented Feb 14, 2020

@kuzzaka sure, lets add it

@kuzzaka
Copy link
Contributor Author

kuzzaka commented Feb 14, 2020

@bkucera done

@kuceb
Copy link
Contributor

kuceb commented Feb 14, 2020

alright, I'm going to rename this to no-force instead of no-force-true and merge

@kuceb kuceb merged commit f43c64e into cypress-io:master Feb 14, 2020
@chrisbreiding
Copy link
Contributor

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuceb kuceb changed the title feat(rule): add 'no-force-true' rule feat(rule): add 'no-force' rule Feb 14, 2020
@abraham-vineti
Copy link

@chrisbreiding It looks like index.js still needs to export this rule.

@kuzzaka
Copy link
Contributor Author

kuzzaka commented Feb 14, 2020

oops

@kuzzaka
Copy link
Contributor Author

kuzzaka commented Feb 14, 2020

I've submitted a fix here #45

jaffrepaul pushed a commit that referenced this pull request Sep 27, 2022
…slint-8.23.1

chore(deps-dev): bump eslint from 8.23.0 to 8.23.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants