Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from ecstatic for serving the built folder #59

Closed
bahmutov opened this issue Jun 8, 2020 · 6 comments
Closed

Move away from ecstatic for serving the built folder #59

bahmutov opened this issue Jun 8, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Jun 8, 2020

In https://github.com/cypress-io/netlify-plugin-cypress/blob/master/src/index.js#L9

function serveFolder (folder, port) {
  const server = ecstatic({
    root: folder
  })
  return http.createServer(server).listen(port)
}

The ecstatic server is deprecated jfhbrook/node-ecstatic#259

It would also be nice if the server had an option to redirect unknown URLs to / to have an option to handle client-side routing as a fallback (#57, #51)

@bahmutov bahmutov added the enhancement New feature or request label Jun 8, 2020
@yixuanhouphl
Copy link

yixuanhouphl commented Jun 16, 2020

@bahmutov Hey there, when do you think this issue would be resolved? Just so I can organise our project that's using the plug-in.

@KunAtCertik
Copy link

KunAtCertik commented Jun 25, 2020

Hey there @bahmutov, any update or ETA on this please?

@bahmutov
Copy link
Contributor Author

bahmutov commented Jun 25, 2020 via email

@KunAtCertik
Copy link

No update, would love a PR but especially with support for redirects

Sent from my iPhone
On Jun 25, 2020, at 19:28, KunAtCertik @.***> wrote:  Hey there @bahmutov, any update on this please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks! That should be enough to resolve #57 (comment)

@bahmutov
Copy link
Contributor Author

bahmutov commented Jun 26, 2020 via email

@bahmutov
Copy link
Contributor Author

done, released in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants