Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme highlight nearly invisible #1

Open
ericjuma opened this issue Sep 25, 2020 · 1 comment
Open

Light theme highlight nearly invisible #1

ericjuma opened this issue Sep 25, 2020 · 1 comment

Comments

@ericjuma
Copy link

In the spacemacs theme, highlight is set to be 4 shades lighter than the background. This is visible with dark themes but not with light themes. It makes helm unusable because it's used for the helm-selection face.

@cyruseuros
Copy link
Owner

Thanks for reporting this! I don't really use light themes much so the odds of me catching this were slim.

I just pushed a change to develop that addresses your problem but might also cause other ones - it inverts the shade number for light colors.

Would you mind setting ewal-dark-pallete-p to t and checking out what your theme looks like on the develop branch now?

I gave it a brief look, and it seems alright, but I'd like your input on any "jarring" changes you see since I'm overly sensitive to the palette itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants