Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-config.sh with dupplicated lines output #751

Closed
llaville opened this issue Nov 15, 2020 · 2 comments
Closed

check-config.sh with dupplicated lines output #751

llaville opened this issue Nov 15, 2020 · 2 comments
Assignees

Comments

@llaville
Copy link
Contributor

ISSUE TYPE

  • Question

SUMMARY

Is it expected to have twice the same output lines in check-config.sh from a new fresh v1.8.2 installation ?

Actual output

# ==============================================================================
# Checking git
# ==============================================================================
[INFO] git is clean

# ==============================================================================
# Checking .env file
# ==============================================================================
[SUCC] .env file exists
[SUCC] .env file is readable
[SUCC] All variables are present in .env file
[SUCC] No variables is duplicated in .env file

# ==============================================================================
# Checking .env file values
# ==============================================================================
[SUCC] All .env file variables have correct values
[SUCC] All .env file variables have correct values

# ==============================================================================
# Checking required directories
# ==============================================================================
[SUCC] All PHP cfg/ sub directories are present
[SUCC] All PHP log/ sub directories are present
[SUCC] All PHP mod/ sub directories are present
[SUCC] All HTTPD cfg/ sub directories are present
[SUCC] All HTTPD log/ sub directories are present

# ==============================================================================
# Checking directory permissions
# ==============================================================================
[SUCC] All devilbox directories have correct permissions
[SUCC] All devilbox directories have correct uid
[SUCC] All devilbox directories have correct gid

# ==============================================================================
# Checking file permissions
# ==============================================================================
[SUCC] All devilbox files have correct permissions
[SUCC] All devilbox files have correct uid
[SUCC] All devilbox files have correct gid

# ==============================================================================
# Checking projects
# ==============================================================================
[SUCC] All project dirs have correct permissions
[SUCC] All project dirs have correct uid
[SUCC] All project dirs have correct gid

# ==============================================================================
# SUMMARY
# ==============================================================================
[SUCC] Found no errors
[INFO] Ensure to run 'docker-compose stop; docker-compose rm -f' when .env was changed

Goal

Removed dupplicated line

# ==============================================================================
# Checking .env file values
# ==============================================================================
[SUCC] All .env file variables have correct values
[SUCC] All .env file variables have correct values

One from https://github.com/cytopia/devilbox/blob/v1.8.2/check-config.sh#L197
and other one from https://github.com/cytopia/devilbox/blob/v1.8.2/check-config.sh#L281

@cytopia
Copy link
Owner

cytopia commented Nov 15, 2020

Thanks for the heads-up!
You can ignore it for now (it won't do any harm). Line 197 is just a leftover which will be removed with the next release.

@cytopia cytopia self-assigned this Nov 15, 2020
@cytopia cytopia mentioned this issue Nov 22, 2020
@cytopia
Copy link
Owner

cytopia commented Nov 22, 2020

Fix released here: #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants