-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom protocols and defining their origin #100
Comments
The most common usage of this middleware would be for normal HTTP and HTTPS usage, so configuration is optimized for that. The origin intent is to allow While I don't really have a strong preference for this style anymore, I'm inclined to leave it as it doesn't break backwards compatibility and your use case is still supported (as a regex). |
I'm sorry to bring this up again after two years, but I have lost many hours on a similar problem, but now involving Ionic. On iOS the Origin header is set to Thus using And I can confirm that Is it worth to mention this behaviour for protocols different than http, https or file? |
I'm developing a Chrome extension and this also sent me on a 3-hour spree until I found this ticket. Thanks for the workaround @stefansundin. Documented + PR: #219 |
After reviewing @aguynamedben documentation PR, I realize I wasn't looking at this issue correctly so I'm re-opening this issue. |
This issue should be fixed with [#225], which is in 2.0.0.rc1 |
Hello there,
I am developing a chrome extension that talks to my website. The extension's origin is
so I naturally defined
in Rack::Cors' configuration.
But it didn't work. I got a 404 on the OPTIONS request. Weird, I though.
After some digging, I found this piece of code:
rack-cors/lib/rack/cors.rb
Line 256 in 42ebe6c
So unless your protocol is http, https, or file, you are not expected to specify the protocol? I tested it and using
origins "bjpcphhoenjjadogjjcelgjnnfgamiog"
worked.What is the reason to even have that else clause? To me it would make sense to change that code to:
I guess I'm mostly confused of the origin of that code? It doesn't seem necessary, isn't explained in the docs as far as I could see, and it prevents you from using arbitrary protocols as strings.
Thanks!
The text was updated successfully, but these errors were encountered: