Make linter significantly more strict

[cdosborn]

Description

Increase linter from "low" to "medium"

Each commit fixes a single lint violation. I don't expect a reviewer to look at each commit. There are only a handful of commits that change more than one line, and they all fell into the same category of issue relating to imports.

File A, would from foo import X, but A would never use X at all. So the linter would suggest to remove that import. However file B, would import X from A. So file B would have to be updated to also import from foo. A file should import a value from the package where the value is defined.

Checklist before merging Pull Requests

• Add an entry in the changelog
• Reviewed and approved by at least one other contributor.

[coveralls]

Coverage decreased (-0.1%) to 37.688% when pulling e1aa39e on cdosborn:lint-medium-strictness into 3348983 on cyverse:master.

[coveralls]

Coverage decreased (-0.1%) to 37.681% when pulling e1aa39e on cdosborn:lint-medium-strictness into 3348983 on cyverse:master.

[coveralls]

Coverage decreased (-0.1%) to 37.864% when pulling 12fed6e on cdosborn:lint-medium-strictness into 47822d4 on cyverse:master.

[coveralls]

Coverage decreased (-0.1%) to 37.681% when pulling e1aa39e on cdosborn:lint-medium-strictness into 3348983 on cyverse:master.

[calvinmclean]

Any tips for reviewing 250+ commits? 😱

[cdosborn]

lol, at the top you'll see there are 464. I don't expect you to review each one. Look at the handful of commits that touch more than one file (or more than one line), maybe try and understand those. Or look at the commit messages and find any linting errors you don't understand and look at those.

[calvinmclean]

Thanks for clarifying all of my questions! Looks good and I am excited to have cleaned up code to work with