-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when syncing Github PR from a deleted repo #247
Comments
Thanks for reporting this @jfrndz, I'll look into it. Is there a chance you could try to clone Buildasaur and run in in the debugger to see exactly what the crash occurs on? That would help out a bunch, otherwise I'll need to do the org/new user/private repo dance myself. Thanks! |
Ah shoot, we just closed the offending PRs as a workaround to get things working. Github won't let me open them up again. Might have some time later this afternoon to recreate the crash though. |
👍 I just need to know what exactly is crashing to know what to fix. Probably we'll just change to error out the sync instead of crashing. |
I'm having trouble building from source. However, I was able to put together a public repo that also triggers the crash. Hope that helps! https://github.com/jfrndz/BuildasaurCrash |
Hi @jfrndz, thanks! I'll need write permissions to be able to setup and debug buildasaur with it. Could you please add me to the repo as a collaborator? Thanks! |
Actually, I managed to isolate the crash anyway. Hmm, since the fork has been deleted, I don't think there's anything Buildasaur can do - it can't check out the repo to test it (because it's gone), so once I fix it it will lead to an error at least. Does that sound reasonable? |
That makes sense. Would Buildasaur still be able to sync healthy PRs in this situation? |
Unfortunately no :( Currently the sync process for each project is independent (so one broken syncer won't affect another one), but syncing of PRs is done in parallel and when anything fails, the syncing bails out with an error. Still tries again in 15seconds as usual (or whatever your sync interval is), but until you close that PR (by merging or closing), that repo won't properly sync. |
- updated for Xcode7.3b5, thus for new Swift version
Thanks for reporting this again, it's fixed by #249. Now the syncer will show an error whenever it encounters this case (instead of crashing the whole app). |
The app crashes to the desktop if there is an open PR from a repo that has been deleted. I've been able to replicate this consistently with the following steps.
$REMOVED_USER
wants to merge 5 commits into$PRIVATE_REPO
fromundefined
"In this state, starting a sync for the private repo should silently crash to the desktop. Here's a crash log.
The text was updated successfully, but these errors were encountered: