Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer warning counts in commits and email text #253

Closed
eric-chamberlain-intel opened this issue Mar 28, 2016 · 9 comments
Closed

Analyzer warning counts in commits and email text #253

eric-chamberlain-intel opened this issue Mar 28, 2016 · 9 comments

Comments

@eric-chamberlain-intel
Copy link

I haven't looked into the code, are the analyzer warning counts available for use in the commit and email text? We'd like developers to be able to see analyzer warning counts along with build warning counts.

@czechboy0
Copy link
Member

You mean in the comments posted by Buildasaur after an integration finishes? Like this one?

If so then yes, all the following counts are included if present:

  • warnings
  • analyzer warnings
  • error
  • test failure
  • code coverage percentage

You can see how it works here.

Is this what you meant? 😊

@eric-chamberlain-intel
Copy link
Author

Yes, does it display all that by default? Our implementation is not displaying analyzer warnings.

We are using the pre-compiled build, if that helps.

@czechboy0
Copy link
Member

Interesting. In those integrations, are you seeing any warnings being mentioned in the comment? I now see that this code will in fact not properly add analyzer warnings if the integration finished with status warnings or passed.

Could you please try to call this on your Xcode Server locally:

curl -k https://127.0.0.1:20343/api/bots

where 127.0.0.1 is the address of the server, so replace it with the proper IP if you're calling it on a local network from a different machine. This will give you a JSON representation of all bots. Please find the one that you're seeing the issue on and find its _id. Then run

curl -k https://127.0.0.1:20343/api/bots/BOT_ID/integrations

and assuming the integration that should be showing analyzer warnings is the last one, it'll be the first in the list. There you should see with which status it ended (succeeded, warnings or analyzerWarnings) and what its buildSummary was. If you can find those two and let me know, I'll understand how to fix it if there's really a bug.

Thanks!

@eric-chamberlain-intel
Copy link
Author

Yes, we have compiler warnings present in the comment.

@eric-chamberlain-intel
Copy link
Author

Here is the relevant curl output:

...
"buildResultSummary":{"analyzerWarningCount":24,"testFailureCount":0,"testsChange":0,"errorCount":0,"testsCount":60,"testFailureChange":0,"warningChange":0,"regressedPerfTestCount":0,"warningCount":5,"errorChange":0,"improvedPerfTestCount":0,"analyzerWarningChange":0,"codeCoveragePercentage":7,"codeCoveragePercentageDelta":0},"result":"warnings"
...

We are running Xcode 7.3.

@czechboy0
Copy link
Member

Thanks! Yeah that's what I thought. I'll fix the bug now, will let you know once a new version with this issue fixed is out. If you're running 1.0-beta2, you'll be able to update directly from Buildasaur.

@czechboy0
Copy link
Member

Done, the release is here: https://github.com/czechboy0/Buildasaur/releases/tag/v1.0.0-b3
And you can just update directly from Buildasaur.

Let me know that it works as you expect now, please! 😊

@eric-chamberlain-intel
Copy link
Author

It works as expected. Thank you for the quick turnaround.

@czechboy0
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants