From 8e36e82a21a95574fbc2cc329be4f2d5e82f6d00 Mon Sep 17 00:00:00 2001
From: Holger Badorreck <6099617+hoba87@users.noreply.github.com>
Date: Sun, 14 Feb 2021 17:30:11 +0100
Subject: [PATCH] update kivy example (#573)

* update old print syntax

* remove pygtk, gtk dependencies

* restore kivy pygtk dependency for linux, add platform dependent conditional statements

* kivy example macos keyboard working

* external pump message only for macos

* Update kivy_.py

Co-authored-by: Czarek Tomczak <cztomczak@users.noreply.github.com>
---
 src/linux/binaries_64bit/kivy_.py | 46 ++++++++++++++++++++-----------
 1 file changed, 30 insertions(+), 16 deletions(-)

diff --git a/src/linux/binaries_64bit/kivy_.py b/src/linux/binaries_64bit/kivy_.py
index bdfb6d2c..49543bf9 100644
--- a/src/linux/binaries_64bit/kivy_.py
+++ b/src/linux/binaries_64bit/kivy_.py
@@ -8,11 +8,20 @@
 
 from cefpython3 import cefpython as cef
 
-import pygtk
-import gtk
 import sys
 import os
 import time
+if sys.platform == 'linux':
+    import pygtk
+    import gtk
+    pygtk.require('2.0')
+elif sys.platform == 'darwin':
+    import gi
+    gi.require_version("Gtk", "3.0")
+    from gi.repository import Gtk
+elif sys.platform == 'win32':
+    # no gtk needed on Windows
+    pass
 
 from kivy.app import App
 from kivy.uix.button import Button
@@ -28,9 +37,6 @@
 # Global variables
 g_switches = None
 
-# PyGTK required
-pygtk.require('2.0')
-
 
 class BrowserLayout(BoxLayout):
 
@@ -150,9 +156,6 @@ def start_cef(self):
 
         # Configure CEF
         settings = {
-            # This directories must be set on Linux
-            "locales_dir_path": cef.GetModuleDirectory()+"/locales",
-            "resources_dir_path": cef.GetModuleDirectory(),
             "browser_subprocess_path": "%s/%s" % (
                 cef.GetModuleDirectory(), "subprocess"),
             "windowless_rendering_enabled": True,
@@ -161,7 +164,15 @@ def start_cef(self):
                 "enabled": False,
             },
             "external_message_pump": False,  # See Issue #246
+            "multi_threaded_message_loop": False,
         }
+        if sys.platform == 'linux':
+            # This directories must be set on Linux
+            settings["locales_dir_path"] = cef.GetModuleDirectory() + "/locales"
+            settings["resources_dir_path"] = cef.GetModuleDirectory()
+        if sys.platform == 'darwin':
+            settings["external_message_pump"] = True  # Temporary fix for Issue #246
+
         switches = {
             # Tweaking OSR performance by setting the same Chromium flags
             # as in upstream cefclient (# Issue #240).
@@ -190,18 +201,21 @@ def start_cef(self):
         # Start idle - CEF message loop work.
         Clock.schedule_once(self._message_loop_work, 0)
 
+        windowInfo = cef.WindowInfo()
+
         # TODO: For printing to work in off-screen-rendering mode
         #       it is enough to call gtk_init(). It is not required
         #       to provide window handle when calling SetAsOffscreen().
         #       However it still needs to be tested whether providing
         #       window handle is required for mouse context menu and
         #       popup widgets to work.
-        gtkwin = gtk.Window()
-        gtkwin.realize()
-
         # WindowInfo offscreen flag
-        windowInfo = cef.WindowInfo()
-        windowInfo.SetAsOffscreen(gtkwin.window.xid)
+        if sys.platform == 'linux':
+            gtkwin = gtk.Window()
+            gtkwin.realize()
+            windowInfo.SetAsOffscreen(gtkwin.window.xid)
+        elif sys.platform == 'darwin' or sys.platform == 'win32':
+            windowInfo.SetAsOffscreen(0)
 
         # Create Broswer and naviagte to empty page <= OnPaint won't get
         # called yet
@@ -519,12 +533,12 @@ def get_windows_key_code(self, kivycode):
 
     def go_forward(self, *_):
         """Going to forward in browser history."""
-        print "go forward"
+        print("go forward")
         self.browser.GoForward()
 
     def go_back(self, *_):
         """Going back in browser history."""
-        print "go back"
+        print("go back")
         self.browser.GoBack()
 
     def reload(self, *_):
@@ -864,7 +878,7 @@ def OnLoadingStateChange(self, is_loading, **_):
     def OnPaint(self, element_type, paint_buffer, **_):
         # print "OnPaint()"
         if element_type != cef.PET_VIEW:
-            print "Popups aren't implemented yet"
+            print("Popups aren't implemented yet")
             return
 
         # FPS meter ("fps" arg)