Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.ticks returns ticks outside domain #162

Closed
dson opened this issue Aug 12, 2020 · 3 comments · Fixed by #164
Closed

Array.ticks returns ticks outside domain #162

dson opened this issue Aug 12, 2020 · 3 comments · Fixed by #164

Comments

@dson
Copy link

dson commented Aug 12, 2020

Array.ticks sometimes returns ticks outside the domain. This is inconsistent with the documentation, that says: each returned tick t satisfies start ≤ t and t ≤ stop. This behavior was introduced in 2.5.0, and probably caused by commit f5883f6.

Example, where tick 3 is outside domain [0, 2.2]:

array.ticks(0, 2.2, 3) // [0, 1, 2, 3]
@Fil
Copy link
Member

Fil commented Aug 12, 2020

Confirmed (both the bug and the commit reference).

@Fil Fil added the bugfix label Aug 12, 2020
@mbostock
Copy link
Member

Good find!

@jheer
Copy link

jheer commented Aug 13, 2020

Thanks @dson for filing the issue. This is breaking Vega as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants