-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Sign in with LinkedIn and introducing OpenID #91
Comments
Hey, thanks for raising this issue. Tbh I don't have time lately to check the impact on it, but since Microsoft is being Microsoft the impact is huge. Anyhow will do spike these days on workload and give ETA on upgrade.. |
Ok just a small update, I made POC and seems like its working. There will be some breaking changes of course for this so cannot just simply patch it, need a bit of testing and then will merge it to technical preview. This will take some days. Documentation for migration of this is really really poor. But in theory from now on when we are creating new app inside linkedin console instead of choosing product sign in, we must include OICD ![]() Also instead of previously called permissions as you said This means that API that was before used to get user information will be deprecated too (even they didn't wrote this anywhere; but you cannot use it without final LinkedInPersonalInfo? firstName;
final LinkedInPersonalInfo? lastName;
final LinkedInProfilePicture? profilePicture;
final String? userId;
final String? localizedFirstName;
final String? localizedLastName;
LinkedInProfileEmail? email;
late LinkedInTokenObject token; We will have something like final String? name;
final String? lastName;
final String? givenName;
final bool? isEmailVerified;
final String? sub;
final String? email;
final String? picture;
final LinkedInPreferredLocal? locale; This is ofc much more readable and easier to access info, but will also mean introducing breaking changes. |
Hey, me once again. I publish Prerelease 3.0.0-beta.1 of this package. Would love to hear feedback from you after trying ;] Thanks again @dzab5 for opening an issue. Migration guid is inside readme.md and small part inside change log, but ofc if you have any doubts let me know. |
Hey @dzab5 did you had chance to test it? Thanks |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hey @RAWAN244, Issue that you are facing is not (at least) shouldn't be connected with this issue and PR. Could you please open new issue with a bit more details (step to reproduce, video maybe, which version of library ur using etc). Thanks |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi @Thelm76 I am not sure how your comment and PR are connected with currently opened issue? Marking it as |
Announcement: I am publishing version Thanks for reporting issue and please create new issue/s if something is wrong with this or any other release. |
Given as linkedin recently deprecated the apis this package uses (https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin).
Is there any plan to adjust this package to use Open Id connect? (https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2).
I am asking because the scopes used by this package of r_profile_lite and r_emailaddress are no longer used, which i believe renders this package obsolete at the moment?
The text was updated successfully, but these errors were encountered: