Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support whitespace control #26

Closed
oliverzy opened this issue Oct 29, 2013 · 4 comments · Fixed by #35
Closed

support whitespace control #26

oliverzy opened this issue Oct 29, 2013 · 4 comments · Fixed by #35

Comments

@oliverzy
Copy link

In the latest handlebars, it has support whitespace control: handlebars-lang/handlebars.js#336

How can modify this plugin to support this feature?

Thanks

@daaain
Copy link
Owner

daaain commented Oct 29, 2013

Nice, haven't even seen this yet!

I've added some tests based on the official Handlebars test suite, see https://github.com/daaain/Handlebars/blob/master/test/inline_script.html#L85

It's going to be a fair bit of work, basically all the opening and closing token regular expressions (\\{\\{ and \\}\\}) will need to be reviewed in the block start / end definitions in Handlebars.JSON-tmLanguage.

@oliverzy
Copy link
Author

yes, understand. but the feature is really cool. looking forward to the new version

@oliverzy
Copy link
Author

oliverzy commented Nov 4, 2013

1.1.0 finally released!
https://github.com/wycats/handlebars.js/blob/master/release-notes.md
Please add support for new whitespace control syntax.

Thanks

@utkarshkukreti
Copy link
Collaborator

@oliverzy I opened a pull request if you'd like to test it - #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants