Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML tags don't match #48

Closed
Frozenfire92 opened this issue Aug 8, 2014 · 6 comments
Closed

HTML tags don't match #48

Frozenfire92 opened this issue Aug 8, 2014 · 6 comments

Comments

@Frozenfire92
Copy link

.hbs file

screen shot 2014-08-08 at 10 30 10 am

.html file

screen shot 2014-08-08 at 10 29 59 am

@daaain
Copy link
Owner

daaain commented Aug 30, 2014

The second one is using the built in HTML package instead of Handlebars, right?

Unfortunately I have no idea why isn't this tag pair highlighting available in the Handlebars package, it's probably something specific to the built in HTML package which is not inherent to the syntax definition which Handlebars is extending.

I'll close this for now as I don't know how to add this functionality to Handlebars, but if you feel like digging into the problem and provide some pointers I'm happy to discuss!

@designorant
Copy link

Workaround

Use BracketHighlighter. It's superior to default tag matching anyway.

On a side note, this shouldn't really be closed just because we don't know how to solve it yet.

@daaain
Copy link
Owner

daaain commented Sep 5, 2014

Thanks @designorant and you're right, I'll reopen in case someone can chime in with some pointers!

@daaain daaain reopened this Sep 5, 2014
@daaain daaain mentioned this issue Sep 16, 2014
@brunowego
Copy link

Thanks @designorant 👍

@daaain
Copy link
Owner

daaain commented Dec 13, 2015

I've added the BracketHighlighter package workaround to the README (thanks @designorant). Closing the issue as it's very unlikely that I'll ever get around to work on this given that there's a perfect solution (and this issue is referenced from the README now), but of course PRs are still welcome.

@daaain daaain closed this as completed Dec 13, 2015
@mmcintyre123
Copy link

The only downside to this is that in order for the BracketHighlighter: Select Bracket Content command to work the cursor has to be on the tag rather than on the tag content you want to select. ctrl+shift+a in HTML works when the cursor is on the tag content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants