-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing gh-pages branch and instead recommending using the master branch even for project pages #505
Comments
There's a situation that one separate these two branches. In case of developping and contributing back to this theme, one might want to test the new features by merging them against the fork's However, there're usually much more users than developers, so perhaps the following line needs to be updated. beautiful-jekyll/staticman.yml Line 28 in 94161db
|
There are certainly cases where gh-pages makes sense, such as when this theme is used as the website of a code project (in which case But I think for the vast majority of users, |
Yeah, of course. Thinking about some recent repos for Beautiful Jekyll sites using names other than |
It looks like to me that, how users are integrating this theme into their workflow is a non-issue, under the context of this report. Be it a fork, file copy or whatever, people always do one thing in common: use the |
@abelcheung those are exactly my thoughts. But I don't want to actually remove the gh-pages branch because it's used to create the demo site, which I do think is useful to have. Do you have an idea what to do about that? Another question I'm not sure about is whether it's even possible to set up the repository so that by default when someone forks it into a project page, it will be configured to serve from master instead of from gh-pages. It seems to me that gh-pages is the default and I can't change that for forks |
This one is very easy. Under Setting → Github Page section, pick
If you want it to be forked, serving as project doc / demonstration website, I can see 2 ways possible to make it happen: Create new repo specific for project doc purposeIn this case, create a separate repo for website purpose only, named like Create new organization userName this organization as your project name, as long as others didn't register same name beforehand. Because each account allows one unsuffixed website, so the theme can be forked, and repo renamed as |
I mean that https://deanattali.com/beautiful-jekyll/ is being served from gh-pages, and I can't serve that from master because master is where the general template is at. The website that i'm serving is a bit different (it has this section for example that I don't want to include in the forked repos) The problem for my second question is that http://deanattali.com/beautiful-jekyll is already being linked from many places so I can't create a different project/organization for the demo website. It needs to live in that URL |
That's your personal domain, not GitHub's one:
|
Thanks for your input Vincent. That is my github.io - deanattali.com is the domain name attached to daattali.github.io (https://github.com/daattali/daattali.github.io/blob/master/CNAME) Creating a new website is not a problem. The problem is that the current one has many links all over the internet, so I do need the previous URL to work. |
I'm not familiar with CNAME, since a GitHub/GitLab domain would satisfy many amateurs like me. I'm just wondering the possibility of setting a redirection https://deanattali.com/beautiful-jekyll/ → https://daattalitest.github.io/ instead of https://deanattali.com/beautiful-jekyll/ → https://daattali.github.io/beautiful-jekyll/ (Edit: corrected links) But it seems that this idea doesn't work due to the CNAME problem that you've just raised. I've read this Stack Overflow answer, which explains some basics that you might know already. Edited: I wonder if setting the Lines 13 to 17 in 94161db
|
This is an odd twist. With so many things set in stone, my take is, bit the bullet and have |
@VincentTam setting baseurl/url on the second account won't work. The domain name that I bought cannot point to two different github users. @abelcheung yeah I may just do that. Although that still leaves one problem: I would love for new users who fork this repository to only have master serve as their website , not gh-pages, without them having to manually change the project settings. I'll email GitHub support to see if that feature can exist :) |
I moved the demo site into docs/ and removed the gh-pages branch. The README has been updated to recommend always using master and how to do it |
GitHub now allows the website to be built directly from the master branch, not only from
gh-pages
. For projects that are primarily a software project, and the code in their git repo is code for their software, it still makes sense to usegh-pages
as their website branch. But since beautifuljekyll it meant to be a website, I think it makes sense for this repository to be served directly frommaster
by default because it's not common that a beautifuljekyll fork needs separatemaster
andgh-pages
branch.If anyone has good reasons against this, please let me know.
The text was updated successfully, but these errors were encountered: