Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tried with Moq and some tests failed #73

Closed
informatorius opened this issue Jun 29, 2018 · 4 comments
Closed

Tried with Moq and some tests failed #73

informatorius opened this issue Jun 29, 2018 · 4 comments
Labels
application The real-world use-case bug help wanted
Milestone

Comments

@informatorius
Copy link

I tried to use FastExpressionCompiler inside Moq source code replacing all Compile() calls with CompileFast(). Most Moq.Tests succeeded but some failed.

@dadhi
Copy link
Owner

dadhi commented Jun 29, 2018

Let's fix them then :) What tests?
Ideally, could you add failing and ignored tests into FEC.IssueTests.

@informatorius
Copy link
Author

  1. Download https://github.com/moq/moq4 latest
  2. Build all
  3. Run Moq.Tests
    => 1000 tests succeeded
  4. Edit 5 moq source files which use Expression.Compile() and replace with Expression.CompileFast()
  5. Build all
  6. Run Moq.Tests again
    => 4 out of 1000 tests failed

@dadhi
Copy link
Owner

dadhi commented Jun 29, 2018

Thanks for the steps! Btw, not bad :)
I would expect more tests to fail.

@informatorius
Copy link
Author

informatorius commented Jun 29, 2018

It is good work so far. Guess not all tests use Expression.Compile()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application The real-world use-case bug help wanted
Projects
None yet
Development

No branches or pull requests

2 participants