Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hot reloading of TLS key stores #1230

Merged
merged 18 commits into from
Mar 11, 2024
Merged

feat: Hot reloading of TLS key stores #1230

merged 18 commits into from
Mar 11, 2024

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Mar 11, 2024

Related issue(s)

closes #1227

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.
  • I have updated the documentation.

Description

This PR makes heimdall listening to changes in configured TLS key stores if secrets_reload_enabled is set to true. This way you can make use of a secret management service of your choice and rotate TLS keys/certificates used by heimdall while listening for incoming connections, as well as used when heimdall communicates to other systems via TLS mutual authentication (as of today only when communicating to Redis cache).

@dadrus dadrus changed the title feat: Hot reloading of the TLS key store feat: Hot reloading of TLS key stores Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.24%. Comparing base (2f9ba81) to head (9b3186d).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/watcher/module.go 0.00% 5 Missing ⚠️
internal/watcher/noop_watcher.go 0.00% 2 Missing ⚠️
internal/watcher/watcher_impl.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
+ Coverage   89.21%   89.24%   +0.03%     
==========================================
  Files         266      269       +3     
  Lines        8771     8837      +66     
==========================================
+ Hits         7825     7887      +62     
- Misses        699      703       +4     
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit 9abf723 into main Mar 11, 2024
27 checks passed
@dadrus dadrus deleted the feat/tls_secrets_reloading branch March 11, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow rotation of TLS server/client certificates without being forced to restart heimdal
1 participant