Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics exposed about certificate expiration can become stale #1536

Closed
3 tasks done
dadrus opened this issue Jun 11, 2024 · 0 comments · Fixed by #1534
Closed
3 tasks done

Metrics exposed about certificate expiration can become stale #1536

dadrus opened this issue Jun 11, 2024 · 0 comments · Fixed by #1534
Labels
bug Something isn't working

Comments

@dadrus
Copy link
Owner

dadrus commented Jun 11, 2024

Preflight checklist

  • I agree to follow this project's Code of Conduct.
  • I have read and am following this repository's Contribution Guidelines."
  • I could not find a solution in the existing issues, docs, nor discussions.

Describe the bug

The PRs #1230 and #1232 have introduced hot reloading of the key stores to allow key rotation without downtimes. Unfortunately, it has been forgotten to update the implementation related to the exposure of certificate expiration metrics. This way, even if the certificates have been rotated, the expiration information of old certificates is still exposed.

How can the bug be reproduced

  1. Start heimdall e.g. in decision with TLS enabled and metrics exposed
  2. Check the certificate expiration metrics
  3. Updated the key store used for TLS with a new key material and certificate
  4. Check the certificate expiration metrics. It is the old one

Relevant log output

No response

Relevant configuration

No response

Version

v0.14.3-alpha

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Docker

Additional Context

No response

@dadrus dadrus added the bug Something isn't working label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant