Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Certificate validation error in JWT finalizer for CA-issued certificates resolved #1900

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Oct 16, 2024

Related issue(s)

closes #1899

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.

Description

CA-issued certificates can now be used in jwt finalizer without the need to add any certificates to heimdall's trust store.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (99e6285) to head (9cefb5b).
Report is 1 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1900      +/-   ##
===========================================
+ Coverage    89.68%   89.75%   +0.06%     
===========================================
  Files          271      271              
  Lines         9154     9156       +2     
===========================================
+ Hits          8210     8218       +8     
+ Misses         700      697       -3     
+ Partials       244      241       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus merged commit 56eefa6 into release Oct 16, 2024
24 checks passed
@dadrus dadrus deleted the fix/jwt_finalizer_cert_validation branch October 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant