Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] Add version control on config.dae #105

Closed
piyoki opened this issue May 29, 2023 · 5 comments
Closed

[Support] Add version control on config.dae #105

piyoki opened this issue May 29, 2023 · 5 comments
Assignees

Comments

@piyoki
Copy link
Contributor

piyoki commented May 29, 2023

What would you like us to support (In short summary)

In future release cycles, we should consider adding a link to point users to the example.dae based on the associated release tag. Consider the following release notes:

Full Changelog: v0.1.10rc...v0.1.10rc1

Example Config: https://github.com/daeuniverse/dae/blob/v0.1.10rc1/example.dae

What's next

We should also make some modifications to the installer script, including logic to pull the latest example.dae for any new future releases.

@piyoki
Copy link
Contributor Author

piyoki commented May 29, 2023

Also, link to #103

@piyoki piyoki changed the title [Support Request] Add version control on config.dae [Support] Add version control on config.dae May 29, 2023
@piyoki
Copy link
Contributor Author

piyoki commented Jun 1, 2023

Installer fix is linked to daeuniverse/dae-installer@5166ea8

@mzz2017
Copy link
Contributor

mzz2017 commented Jun 3, 2023

I don't think we should add version related files in main branch. It should be controlled using git in different tags. It is natural supported.

@piyoki
Copy link
Contributor Author

piyoki commented Jun 3, 2023

I don't think we should add version related files in main branch. It should be controlled using git in different tags. It is natural supported.

Yes, I agree. I think all we need is to add the following to future releases:

Full Changelog: v0.1.10rc...v0.1.10rc1
Example Config: https://github.com/daeuniverse/dae/blob/v0.1.10rc1/example.dae

@mzz2017
Copy link
Contributor

mzz2017 commented Jun 3, 2023

Yes, I agree. I think all we need is to add the following to future releases:

I got it. It is a good idea.

@piyoki piyoki closed this as completed Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants