Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browersify build breaks with Require.js in browser #156

Closed
rbkreisberg opened this issue Oct 30, 2014 · 2 comments
Closed

Browersify build breaks with Require.js in browser #156

rbkreisberg opened this issue Oct 30, 2014 · 2 comments

Comments

@rbkreisberg
Copy link

Using the current build of dagre.js with Require.js in browser results in errors related to references to graphlib and lodash.

I was able to resolve this by building it with the fix from:

dagrejs/dagre-d3#103

browserify index.js -s dagre > dist/dagre.js
@cpettitt
Copy link
Collaborator

I'm pushing this change shortly. Any ideas on an easy way to validate that this works automatically?

@rbkreisberg
Copy link
Author

Probably a test written for PhantomJS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpettitt @rbkreisberg