Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in computation of node positions #453

Open
Schichael opened this issue Sep 24, 2024 · 1 comment
Open

Bugs in computation of node positions #453

Schichael opened this issue Sep 24, 2024 · 1 comment

Comments

@Schichael
Copy link

Schichael commented Sep 24, 2024

Hello,
the computation of the positions of nodes has bugs. These bugs become visible when you use nodes with different dimensions.
The bug in horizontal direction (the nodes should not be overlapping):
grafik
In vertical direction (again, the nodes should not be overlapping):
grafik

The issue for the horizontal position lies in the sep() function in dagre/lib/position/bk.js
Here, the half widths of both nodes are added. But the full width of the first node should be used.

The issue for the vertical position lies in the positionY() function in dagre/lib/position/index.js.

@jingmiaohe
Copy link

jingmiaohe commented Nov 11, 2024

absolutely agree with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants