From 02d69d990d17881d0cc81b10c7c89fefbe2844e6 Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Thu, 23 May 2024 09:39:20 -0500 Subject: [PATCH] Revert "Pin requests < 2.32.0" (#22055) Reverts dagster-io/dagster#21977 Docker has released a new version and requests has yanked the offending versions so we should be able to remove this pin before our release goes out this week. --- .../backcompat-test-suite/webserver_service/pins.txt | 5 +---- python_modules/dagster/setup.py | 1 - python_modules/libraries/dagster-celery-docker/setup.py | 1 - python_modules/libraries/dagster-docker/setup.py | 7 +------ 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt b/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt index 37a1279c09a63..6c56c9119918d 100644 --- a/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt +++ b/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt @@ -15,7 +15,4 @@ grpcio<1.48.1; python_version < '3.10' sqlalchemy<2.0.0 # Added pendulum pin in later versions -pendulum<3 - -# 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 -requests<2.32.0 +pendulum<3 \ No newline at end of file diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py index fb42ff2abec8b..28d59d9014c51 100644 --- a/python_modules/dagster/setup.py +++ b/python_modules/dagster/setup.py @@ -138,7 +138,6 @@ def get_version() -> str: "morefs[asynclocal]", "fsspec<2024.5.0", # morefs incompatibly "rapidfuzz", - "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 ], "mypy": ["mypy==1.8.0"], "pyright": [ diff --git a/python_modules/libraries/dagster-celery-docker/setup.py b/python_modules/libraries/dagster-celery-docker/setup.py index f10291fccd5ad..8fd3f2124b706 100644 --- a/python_modules/libraries/dagster-celery-docker/setup.py +++ b/python_modules/libraries/dagster-celery-docker/setup.py @@ -36,7 +36,6 @@ def get_version() -> str: f"dagster-celery{pin}", f"dagster-graphql{pin}", "docker", - "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 ], zip_safe=False, ) diff --git a/python_modules/libraries/dagster-docker/setup.py b/python_modules/libraries/dagster-docker/setup.py index b283f780239ba..e23b719dbf738 100644 --- a/python_modules/libraries/dagster-docker/setup.py +++ b/python_modules/libraries/dagster-docker/setup.py @@ -34,11 +34,6 @@ def get_version() -> str: ], packages=find_packages(exclude=["dagster_docker_tests*"]), python_requires=">=3.8,<3.13", - install_requires=[ - f"dagster{pin}", - "docker", - "docker-image-py", - "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 - ], + install_requires=[f"dagster{pin}", "docker", "docker-image-py"], zip_safe=False, )