From 7ebacfa0ff230ecbf7dd73b32b792d99bcdd050d Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 12:20:24 -0500 Subject: [PATCH 1/9] Pin requests < 2.32.0 While we investigate breaking docker tests: https://buildkite.com/dagster/dagster-dagster/builds/83562 --- python_modules/dagster/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py index 1dbafc1069314..4d10c4e48dd18 100644 --- a/python_modules/dagster/setup.py +++ b/python_modules/dagster/setup.py @@ -96,7 +96,7 @@ def get_version() -> str: "python-dateutil", "python-dotenv", "pytz", - "requests", + "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 "setuptools", "tabulate", "tomli<3", From 697e104ff7ec5659af1fa79bfdeee944ea96557e Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 12:34:15 -0500 Subject: [PATCH 2/9] Move pin into dagster-docker --- python_modules/dagster/setup.py | 2 +- python_modules/libraries/dagster-docker/setup.py | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py index 4d10c4e48dd18..1dbafc1069314 100644 --- a/python_modules/dagster/setup.py +++ b/python_modules/dagster/setup.py @@ -96,7 +96,7 @@ def get_version() -> str: "python-dateutil", "python-dotenv", "pytz", - "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 + "requests", "setuptools", "tabulate", "tomli<3", diff --git a/python_modules/libraries/dagster-docker/setup.py b/python_modules/libraries/dagster-docker/setup.py index e23b719dbf738..b283f780239ba 100644 --- a/python_modules/libraries/dagster-docker/setup.py +++ b/python_modules/libraries/dagster-docker/setup.py @@ -34,6 +34,11 @@ def get_version() -> str: ], packages=find_packages(exclude=["dagster_docker_tests*"]), python_requires=">=3.8,<3.13", - install_requires=[f"dagster{pin}", "docker", "docker-image-py"], + install_requires=[ + f"dagster{pin}", + "docker", + "docker-image-py", + "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 + ], zip_safe=False, ) From 475f7c87195c4b07700f276862896386188972cc Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 12:36:23 -0500 Subject: [PATCH 3/9] [NO_SKIP=True] Trigger full build From 67ffb02df12e5ba559bd720434b98b73c20967d0 Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 12:47:19 -0500 Subject: [PATCH 4/9] Also pin in celery docker --- python_modules/libraries/dagster-celery-docker/setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/libraries/dagster-celery-docker/setup.py b/python_modules/libraries/dagster-celery-docker/setup.py index 8fd3f2124b706..f10291fccd5ad 100644 --- a/python_modules/libraries/dagster-celery-docker/setup.py +++ b/python_modules/libraries/dagster-celery-docker/setup.py @@ -36,6 +36,7 @@ def get_version() -> str: f"dagster-celery{pin}", f"dagster-graphql{pin}", "docker", + "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 ], zip_safe=False, ) From 7392541d7b56115c2a58256ca473c1f5382efe4d Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 12:47:25 -0500 Subject: [PATCH 5/9] [NO_SKIP=True] Trigger full build From be2de5f756cbd23d2c1aa5c90137041ab692e2ca Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 13:05:42 -0500 Subject: [PATCH 6/9] Also pin in dagster[test] --- python_modules/dagster/setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py index 1dbafc1069314..f52c2f44293a3 100644 --- a/python_modules/dagster/setup.py +++ b/python_modules/dagster/setup.py @@ -138,6 +138,7 @@ def get_version() -> str: "morefs[asynclocal]", "fsspec<2024.5.0", # morefs incompatibly "rapidfuzz", + "requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 ], "mypy": ["mypy==1.8.0"], "pyright": [ From ee8a977aba93b5f20d12da3e8e8b7a49de29a0ef Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 13:05:55 -0500 Subject: [PATCH 7/9] [NO_SKIP=True] Trigger full build From 859c4d0014de43b1313197336126d68b130db6b9 Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 14:29:59 -0500 Subject: [PATCH 8/9] Pin in backcompat webserver service --- .../backcompat-test-suite/webserver_service/pins.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt b/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt index 6c56c9119918d..37a1279c09a63 100644 --- a/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt +++ b/integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt @@ -15,4 +15,7 @@ grpcio<1.48.1; python_version < '3.10' sqlalchemy<2.0.0 # Added pendulum pin in later versions -pendulum<3 \ No newline at end of file +pendulum<3 + +# 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562 +requests<2.32.0 From 5f6b2fa913a0c5923946e16db099b952b765ce09 Mon Sep 17 00:00:00 2001 From: Jordan Sanders Date: Mon, 20 May 2024 14:30:04 -0500 Subject: [PATCH 9/9] [NO_SKIP=True] Trigger full build