Dailymotion Bid Adaptor: Add standard ORTB video parameters #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-le-dev
approved these changes
Apr 19, 2024
sebmil-daily
force-pushed
the
GLUE-16296_handle_ortb_video_fields
branch
from
b4f2c58 to
a934c48
Compare
kvnsw
requested changes
Apr 19, 2024
kvnsw
changed the title
Note: I changed the case of `startdelay` to be consistent with the other parameters, but it won't have any impact on current deployments as this parameter is not used onsite.
sebmil-daily
force-pushed
the
GLUE-16296_handle_ortb_video_fields
branch
from
a934c48 to
729647b
Compare
kvnsw
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I changed the case of
startdelayto be consistent with the other parameters, but it won't have any impact on current deployments as this parameter is not used onsite.I also removed
playerSizeto use the more standard dimensions inwandh.