Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema and Operations directives #134

Closed
Maximilien-R opened this issue Mar 1, 2019 · 1 comment · Fixed by #308
Closed

Schema and Operations directives #134

Maximilien-R opened this issue Mar 1, 2019 · 1 comment · Fixed by #308
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Maximilien-R
Copy link
Member

Directives on schema doesn't seems to be executed.

  • Tartiflette version: 0.4.0
  • Python version: 3.7.1
  • Executed in docker: No
  • Is a regression from a previous versions? No

SDL example:

directive @non_introspectable on SCHEMA | FIELD_DEFINITION

type Query {
  aField: String
}

schema @nonIntrospectable {
  query: Query
}

Directive:

import logging

from typing import Any, Callable, Dict

from tartiflette.directive import CommonDirective, Directive

logger = logging.getLogger(__name__)


@Directive("nonIntrospectable")
class NonIntrospectable(CommonDirective):
    @staticmethod
    def on_introspection(
        _directive_args: Dict[str, Any],
        _next_directive: Callable,
        _introspected_element: Any,
    ) -> None:
        logger.debug(">> NonIntrospectable.on_introspection")
        return None

When querying, the log is never triggered.

@Maximilien-R Maximilien-R added the bug Something isn't working label Mar 1, 2019
@Maximilien-R Maximilien-R added this to the road-to-v1 milestone Mar 1, 2019
@abusi abusi self-assigned this Mar 14, 2019
@remorses

This comment has been minimized.

@abusi abusi added enhancement New feature or request and removed bug Something isn't working labels Aug 12, 2019
@abusi abusi modified the milestones: road-to-v1, v1.1 Aug 12, 2019
@abusi abusi changed the title Schema directives aren't executed Schema and Operations directives Aug 12, 2019
@abusi abusi changed the title Schema and Operations directives Schema directives Aug 12, 2019
@abusi abusi changed the title Schema directives Schema and Operations directives Aug 12, 2019
@abusi abusi mentioned this issue Oct 1, 2019
4 tasks
@abusi abusi closed this as completed in #308 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants