-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep up to date with changes in the engine regarding TTS configuration #238
Comments
This will require backend changes only: this will have to be specified either at launch time, or through the settings API (like is already the case for other settings such as speech-rate) |
Setting the "org.daisy.pipeline.tts.config" property at launch time is already possible and will be the most straightforward solution, and should give us exactly the same behavior. Setting the property dynamically through the settings API is not possible yet today, but I'm about to change that. The main benefit of this approach is that changing a property affects the jobs created after the change, but not the jobs created before the change (but still in the cueue). So through the dynamic approach, you could in theory create a new TTS configuration file after each change. |
Instead of using a script option to point to a TTS configuration file, the TTS configuration file can be passed at launch time via the org.daisy.pipeline.tts.config property. |
@bertfrees will the scripts still have a tts config option? Not that we would use it. But I need to know if I still need to filter it out on the script form. |
I will keep it around for now. An alternative the the script option is also still needed for the command line interface. |
daisy/pipeline-modules#66
The text was updated successfully, but these errors were encountered: