Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep up to date with changes in the engine regarding TTS configuration #238

Open
marisademeglio opened this issue Jun 24, 2024 · 5 comments
Assignees
Labels
engine Issues that require something to change on the engine side
Milestone

Comments

@marisademeglio
Copy link
Member

daisy/pipeline-modules#66

@marisademeglio marisademeglio added this to the 1.6 milestone Jun 24, 2024
@marisademeglio marisademeglio added the engine Issues that require something to change on the engine side label Jun 24, 2024
@marisademeglio marisademeglio changed the title Keep up to date with change in the engine regarding TTS configuration Keep up to date with changes in the engine regarding TTS configuration Jun 24, 2024
@marisademeglio
Copy link
Member Author

This will require backend changes only: this will have to be specified either at launch time, or through the settings API (like is already the case for other settings such as speech-rate)

https://daisy-dev.slack.com/archives/C064GB8U9/p1723476887384829?thread_ts=1723476120.081709&cid=C064GB8U9

@bertfrees
Copy link
Member

Setting the "org.daisy.pipeline.tts.config" property at launch time is already possible and will be the most straightforward solution, and should give us exactly the same behavior.

Setting the property dynamically through the settings API is not possible yet today, but I'm about to change that. The main benefit of this approach is that changing a property affects the jobs created after the change, but not the jobs created before the change (but still in the cueue). So through the dynamic approach, you could in theory create a new TTS configuration file after each change.

@marisademeglio marisademeglio modified the milestones: 1.6, 1.7 Oct 7, 2024
@bertfrees bertfrees moved this from In Progress to Cancelled in Pipeline 2 | October 2024 release Nov 11, 2024
@marisademeglio
Copy link
Member Author

Instead of using a script option to point to a TTS configuration file, the TTS configuration file can be passed at launch time via the org.daisy.pipeline.tts.config property.

@marisademeglio
Copy link
Member Author

@bertfrees will the scripts still have a tts config option? Not that we would use it. But I need to know if I still need to filter it out on the script form.

@bertfrees
Copy link
Member

I will keep it around for now. An alternative the the script option is also still needed for the command line interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues that require something to change on the engine side
Projects
Status: Cancelled
Development

No branches or pull requests

2 participants