Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New std lib unique,iter in go1.23 can not be recognized #209

Open
Zxilly opened this issue Jul 7, 2024 · 5 comments · May be fixed by #208
Open

New std lib unique,iter in go1.23 can not be recognized #209

Zxilly opened this issue Jul 7, 2024 · 5 comments · May be fixed by #208
Labels
good first issue Good for newcomers

Comments

@Zxilly
Copy link

Zxilly commented Jul 7, 2024 •
edited
Loading

What version of GCI are you using?

0.13.4

Reproduce Steps

Just run with a file using the unique

What did you expect to see?

unique should be regarded as std lib and stay with other std libs.

What did you see instead?

unique was regarded as third party library.
@Zxilly Zxilly changed the title New std lib unique can not be recognized New std lib unique in go1.23 can not be recognized Jul 7, 2024
@Zxilly Zxilly changed the title New std lib unique in go1.23 can not be recognized New std lib unique,iter in go1.23 can not be recognized Jul 7, 2024
@daixiang0
Copy link
Owner

daixiang0 commented Jul 8, 2024 •
edited
Loading

Refer to https://pkg.go.dev/unique, it is introduced by 1.23rc1, since now 1.23 is not released yet, please wait it.

@daixiang0 daixiang0 added the good first issue Good for newcomers label Jul 8, 2024
@Zxilly
Copy link
Author

Zxilly commented Jul 8, 2024 •
edited
Loading

Please take a look at #208

@Zxilly
Copy link
Author

Zxilly commented Aug 13, 2024

@daixiang0 Go1.23 has been generally available, please review the PR.

@Zxilly Zxilly linked a pull request Aug 13, 2024 that will close this issue
Open
@silas silas mentioned this issue Aug 22, 2024
Merged
@esimonov
Copy link

I believe this can be closed now? It works, including golangci-lint since version 1.61.0.

@Zxilly
Copy link
Author

Zxilly commented Sep 12, 2024

syscall/js still not included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: scrape all goos/goarch pair for stdlib Zxilly/gci
3 participants
@esimonov @daixiang0 @Zxilly