Bug: Lexical parser prohibits querying on fieldnames containing a questionmark

[elofu17]

For some reason, the puppetdb people thought it was a good idea to have a questionmark in one of the Events fieldnames: "latest_report?"

From the Events manual (https://docs.puppet.com/puppetdb/4.0/api/query/v4/events.html):
latest_report? (Boolean): whether the event occurred in the most recent Puppet run (per-node).

The github project Puppet Explorer (https://github.com/spotify/puppetexplorer/) use 'node-puppetdbquery'.

If I do a query for "#event.latest_report?=true", Puppet Explorer show me a red banner complaining about:

Lexical error on line 1. Unrecognized text. 
#event.latest_report?=true
--------------------^

If I try removing the questionmark, I get a red banner stating that I should use a fieldname with the questionmark:

'latest_report' is not a queryable object for events, known queryable objects are ["certname","configuration_version","containing_class","containment_path", "environment","file","latest_report?","line","message","new_value","old_value","property","report",
"report_receive_time","resource_title","resource_type","run_end_time","run_start_time","status",
"timestamp"]

See the "latest_report?" there in the middle.

Can you please make the lexical parser not bail on the questionmark character?
The error is generated here:

node-puppetdbquery/build/parser.js

Line 586 in 445ff5b

return this.parseError('Lexical error on line ' + (this.yylineno + 1) + '. Unrecognized text.\n' + this.showPosition(), {

[elofu17]

A colleague of mine solved it for me:

In line 713 (

node-puppetdbquery/build/parser.js

Line 713 in 445ff5b

rules: [/^(?:\s+)/,/^(?:\()/,/^(?:\))/,/^(?:\[)/,/^(?:\])/,/^(?:\{)/,/^(?:\})/,/^(?:=)/,/^(?:!=)/,/^(?:~)/,/^(?:!~)/,/^(?:<=)/,/^(?:>=)/,/^(?:>)/,/^(?:<)/,/^(?:\*)/,/^(?:#)/,/^(?:not\b)/,/^(?:and\b)/,/^(?:or\b)/,/^(?:true\b)/,/^(?:false\b)/,/^(?:-?\d+)/,/^(?:"(\\.|[^\\"])*")/,/^(?:'(\\.|[^\\'])*')/,/^(?:\.)/,/^(?:[-\w_:]+)/,/^(?:@@)/,/^(?:@)/,/^(?:$)/],

), add a "?" to the 4th expression at the end, "/^(?:[-\w_:]+)/," --> "/^(?:[-\w_?:]+)/,"

Like this:
rules: [/^(?:\s+)/,/^(?:()/,/^(?:))/,/^(?:[)/,/^(?:])/,/^(?:{)/,/^(?:})/,/^(?:=)/,/^(?:!=)/,/^(?:)/,/^(?:!)/,/^(?:<=)/,/^(?:>=)/,/^(?:>)/,/^(?:<)/,/^(?:*)/,/^(?:#)/,/^(?:not\b)/,/^(?:and\b)/,/^(?:or\b)/,/^(?:true\b)/,/^(?:false\b)/,/^(?:-?\d+)/,/^(?:"(.|[^\"])")/,/^(?:'(.|[^\'])')/,/^(?:.)/,/^(?:[-\w_:]+)/,/^(?:@@)/,/^(?:@)/,/^(?:$)/],

Is changed to:
rules: [/^(?:\s+)/,/^(?:()/,/^(?:))/,/^(?:[)/,/^(?:])/,/^(?:{)/,/^(?:})/,/^(?:=)/,/^(?:!=)/,/^(?:)/,/^(?:!)/,/^(?:<=)/,/^(?:>=)/,/^(?:>)/,/^(?:<)/,/^(?:*)/,/^(?:#)/,/^(?:not\b)/,/^(?:and\b)/,/^(?:or\b)/,/^(?:true\b)/,/^(?:false\b)/,/^(?:-?\d+)/,/^(?:"(.|[^\"])")/,/^(?:'(.|[^\'])')/,/^(?:.)/,/^(?:[-\w_?:]+)/,/^(?:@@)/,/^(?:@)/,/^(?:$)/],

Now I can execute queries that use the "latest_report?" fieldname, like this:
#report { latest_report?=true and noop=true and status="unchanged" }

Unless this change allow too much or makes something insecure, please update your code accordingly.

[dalen]

it is possible to just quote the property in the query, like #event."latest_report?"=true. But it is a bit silly to have to do that, so I'll fix it.

[elofu17]

:-)
Thanks!