Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed][Waiting for implementaiton] Brightness keys aren't working #7

Closed
kvn1351 opened this issue Jan 26, 2018 · 5 comments
Closed
Labels
Keyboard Keyboard related issue

Comments

@kvn1351
Copy link

kvn1351 commented Jan 26, 2018

Please fix the brightness control, so that we can use the hardware keys to control it.

Everything else works great, thanks a lot!

OS version: 10.13.3

@kvn1351 kvn1351 changed the title Brightness keys aren't working. [BUG] Brightness keys aren't working Jan 26, 2018
@gplast
Copy link

gplast commented Jan 26, 2018

You can easily enable brightness keys by using the FN+F4 and FN+F5. You have to go to Settings->Keyboard->Shortcuts->Display and check Decrease/Increase display brightness. Double click next to Decrease/Increase display brightness and press FN+F4 / FN+F5. Now you can Control Brightness easily with these keys(I hope that helps).

@kvn1351
Copy link
Author

kvn1351 commented Jan 26, 2018

@gplast Thanks a lot for your answer. I already knew of this workaround, you could also use BetterTouchTool to get it even nicer (without FN), but I wanted to file a report of this bug nonetheless.

It's not a big issue, but it would be nice if it could get sorted.

Edit: I was wrong. You have to use FN cause the buttons aren't registered at all. I thought that they were at least registering something. I've fixed it though with a patch, read below.

@gplast
Copy link

gplast commented Jan 26, 2018

Okay, i use BetterTouchTool to control play/pause but i will give it a try. Thank you.

@kvn1351
Copy link
Author

kvn1351 commented Jan 29, 2018

I've managed to patch the ACPI to fix the brightness keys. However it's a static patch, i.e. a patched DSDT.aml. It works great and all, but it would be cool if I could create a hotpatch of it instead.

I'm not experienced enough with SSDT hotpatching though, so if there's someone who could help with some "External" declarations, please send me a message.

The patched method is huge and contains tons of references that have to be declared, I've fixed most of them, but some are still acting up..

Now I'll try to fix the HDMI issue.

@kvn1351 kvn1351 changed the title [BUG] Brightness keys aren't working [Fixed][Waiting for implementaiton] Brightness keys aren't working Jan 29, 2018
@daliansky
Copy link
Owner

As for brightness keys, I tried changing the default keymaps (f14/f15) to f4/f5, and the brightness control is working as well. I can't quite tell the difference between these and the native keystrokes (fn+f4/f5).
qq20180203-224539 2x
Appreciate you guys' hard work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keyboard Keyboard related issue
Projects
None yet
Development

No branches or pull requests

4 participants