Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pong data is missing #232

Closed
nonameplum opened this issue Aug 18, 2016 · 3 comments
Closed

Pong data is missing #232

nonameplum opened this issue Aug 18, 2016 · 3 comments

Comments

@nonameplum
Copy link

nonameplum commented Aug 18, 2016

Hi,

I wonder why Starscream doesn't handle data that may be included in pong message sent from web socket. According to the web socket's specs:
https://tools.ietf.org/html/rfc6455#section-5.5.2

@acmacalister
Copy link
Collaborator

Thanks for including the RFC reference. I'm not sure what you mean? Starscream responses with a Pong to any Ping data, which according to the spec, should be the same data as the Ping. Are you seeing something different?

@nonameplum
Copy link
Author

nonameplum commented Aug 19, 2016

onPongcallback and delegate doesn't have data passed in it as in onText or onData.
But in my opinion as RFC reference is saying that pong may has data so Starscream should pass it as optional parameter.

@daltoniam
Copy link
Owner

I added this to the Swift 3 branch (2.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants