Prevent reconnection crash #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code only prevented a second connection to be created while createHTTPRequest was being called (setting up the HTTP request and the streams). However, between the time when the socket opens the streams until the TCP handshake ends, it would be both `!conneted` and `!isConnecting`, which wouldn't prevent a second `connect`.
Since `disconnect` without a timeout only sends a close message to the server, if we tried to `connect` the socket again before the connection was closed it would not clean up the streams properly, which could result in a crash. See daltoniam#272
|
Ah very good. Thank you for the great write up and PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple cases where a socket would create a new connection without closing an existing one.
!connectedand!isConnecting, so a secondconnectwould go through creating a new pair of streams without disconnecting the first pair.disconnectwithout a timeout only sends a close message to the server, if we tried toconnectthe socket again before the connection was closed it would not disconnect the previous streams.In any of those cases we end up with a
NSInputStreamthat still has theWebSocketas a delegate, but it's no longer referenced ininputStream. If theWebSocketis deallocated, it wouldn't clean up the delegate on that stream, and if it received any data, it would try to forward it to a deallocated object, which would crash.This should fix #272