Why is a close code of 1012 considered a protocol error?

[p0fi]

Hi,

im wondering why the following lines

Starscream/Source/WebSocket.swift

Lines 805 to 807 in 6dc9cdf

	if closeCode < 1000 || (closeCode > 1003 && closeCode < 1007) || (closeCode > 1011 && closeCode < 3000) {
	closeCode = CloseCode.protocolError.rawValue
	}

assume that a close code of 1012 is a protocol error?

The code seems to be added as an extension of RFC 6455 here: https://www.ietf.org/mail-archive/web/hybi/current/msg09670.html

The web API description by mozilla (link) also lists 1012 as a valid close code with the meaning

Service Restart - The server is terminating the connection because it is restarting.

[acmacalister]

Yeah, those opcode aren't apart of the 6455 RFC spec, but you are correct that they appears to have been added to the official IANA registry. Starscream was designed against the original 6455 RFC spec, so that is why we made an assumption those were protocol errors. They were updated in the autobahn test suite (see crossbario/autobahn-testsuite#52 for more info), so we will go ahead and update them accordingly in Starscream. Thanks for the report.

[daltoniam]

Version 3.0.0 has been released with a fix for this!

[karthik55]

I am getting ProtocolError With close Code 1000 and Message is Empty, any one come across issue. If so could you tell me the reason for the issue.