Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Bearer Token Fetching #8

Open
dan-mcm opened this issue Jun 7, 2020 · 2 comments
Open

Multiple Bearer Token Fetching #8

dan-mcm opened this issue Jun 7, 2020 · 2 comments
Labels
techdebt Legacy code that needs love

Comments

@dan-mcm
Copy link
Owner

dan-mcm commented Jun 7, 2020

Currently a new bearer token is requested everytime a call to twitch is made, segment this logic out so its only fetched once every hour or so and written to a variable or some similar config solution.
@dan-mcm dan-mcm added the bug Something isn't working label Jun 7, 2020
@dan-mcm
Copy link
Owner Author

dan-mcm commented Jun 7, 2020

sub-issue -> duplication call of getBearerToken -> should be able to implicitly pass the token downwards instead of asking additional details

@dan-mcm
Copy link
Owner Author

dan-mcm commented Jun 8, 2020

As using Promise.all this can definitely be optimzed now.

@dan-mcm dan-mcm changed the title Bearer Token Fetching Multiple Bearer Token Fetching Jun 8, 2020
@dan-mcm dan-mcm added techdebt Legacy code that needs love and removed bug Something isn't working labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
techdebt Legacy code that needs love
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dan-mcm