refactor(check): misc. renaming and refactoring

dan-tripp · Oct 27, 2021 · 60455a7 · 60455a7
1 parent 5920728
commit 60455a7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/lib/checks/keyboard/frame-focusable-content-evaluate.js b/lib/checks/keyboard/frame-focusable-content-evaluate.js
@@ -18,7 +18,7 @@ function focusableDescendants(vNode) {
   });
 }
 
-function noFocusableContentForFrameEvaluate(node, options, virtualNode) {
+function frameFocusableContentEvaluate(node, options, virtualNode) {
   if (!virtualNode.children) {
     return undefined;
   }
@@ -32,4 +32,4 @@ function noFocusableContentForFrameEvaluate(node, options, virtualNode) {
   }
 }
 
-export default noFocusableContentForFrameEvaluate;
+export default frameFocusableContentEvaluate;
diff --git a/lib/checks/keyboard/frame-focusable-content.json b/lib/checks/keyboard/frame-focusable-content.json
@@ -1,6 +1,6 @@
 {
   "id": "frame-focusable-content",
-  "evaluate": "no-focusable-content-for-frame-evaluate",
+  "evaluate": "frame-focusable-content-evaluate",
   "metadata": {
     "impact": "serious",
     "messages": {

diff --git a/lib/checks/keyboard/no-focusable-content-evaluate.js b/lib/checks/keyboard/no-focusable-content-evaluate.js
@@ -14,7 +14,7 @@ function getFocusableDescendants(vNode) {
     if(isFocusable(child)) {
       retVal.push(child);
     } else {
-      getFocusableDescendants(child).forEach(descendantOfChild => retVal.push(descendantOfChild));
+      retVal.push(...getFocusableDescendants(child));
     }
   });
   return retVal;
@@ -32,7 +32,7 @@ function noFocusableContentEvaluate(node, options, virtualNode) {
   try {
     const focusableDescendants = getFocusableDescendants(virtualNode);
     if(focusableDescendants.length > 0) {
-      const notHiddenElements = focusableDescendants.filter(descendant => usesUnreliableHidingStrategy(descendant));
+      const notHiddenElements = focusableDescendants.filter(usesUnreliableHidingStrategy);
       if(notHiddenElements.length > 0) {
         this.data({ messageKey: 'notHidden' });
         this.relatedNodes(notHiddenElements);

diff --git a/lib/core/base/metadata-function-map.js b/lib/core/base/metadata-function-map.js
@@ -96,7 +96,7 @@ import focusableModalOpenEvaluate from '../../checks/keyboard/focusable-modal-op
 import focusableNoNameEvaluate from '../../checks/keyboard/focusable-no-name-evaluate';
 import focusableNotTabbableEvaluate from '../../checks/keyboard/focusable-not-tabbable-evaluate';
 import landmarkIsTopLevelEvaluate from '../../checks/keyboard/landmark-is-top-level-evaluate';
-import noFocusableContentForFrameEvaluate from '../../checks/keyboard/frame-focusable-content-evaluate';
+import frameFocusableContentEvaluate from '../../checks/keyboard/frame-focusable-content-evaluate';
 import noFocusableContentEvaluate from '../../checks/keyboard/no-focusable-content-evaluate';
 import tabindexEvaluate from '../../checks/keyboard/tabindex-evaluate';
 
@@ -274,7 +274,7 @@ const metadataFunctionMap = {
   'focusable-no-name-evaluate': focusableNoNameEvaluate,
   'focusable-not-tabbable-evaluate': focusableNotTabbableEvaluate,
   'landmark-is-top-level-evaluate': landmarkIsTopLevelEvaluate,
-  'no-focusable-content-for-frame-evaluate': noFocusableContentForFrameEvaluate,
+  'frame-focusable-content-evaluate': frameFocusableContentEvaluate,
   'no-focusable-content-evaluate': noFocusableContentEvaluate,
   'tabindex-evaluate': tabindexEvaluate,