From ed5e69d7e6eaf5e887ff48aa3fe941d394c44846 Mon Sep 17 00:00:00 2001 From: Beni von Cheni Date: Fri, 22 Mar 2019 00:22:42 -0400 Subject: [PATCH] console: use consolePropAttributes for k-bind properties in constructor PR-URL: https://github.com/nodejs/node/pull/26850 Reviewed-By: Joyee Cheung Reviewed-By: Yongsheng Zhang Reviewed-By: Ruben Bridgewater --- lib/internal/console/constructor.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js index b00707d1fda365..fadb80e707c867 100644 --- a/lib/internal/console/constructor.js +++ b/lib/internal/console/constructor.js @@ -181,15 +181,13 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) { ...consolePropAttributes, value: Boolean(ignoreErrors) }, - '_times': { ...consolePropAttributes, value: new Map() } + '_times': { ...consolePropAttributes, value: new Map() }, + // Corresponds to https://console.spec.whatwg.org/#count-map + [kCounts]: { ...consolePropAttributes, value: new Map() }, + [kColorMode]: { ...consolePropAttributes, value: colorMode }, + [kIsConsole]: { ...consolePropAttributes, value: true }, + [kGroupIndent]: { ...consolePropAttributes, value: '' } }); - - // TODO(joyeecheung): use consolePropAttributes for these - // Corresponds to https://console.spec.whatwg.org/#count-map - this[kCounts] = new Map(); - this[kColorMode] = colorMode; - this[kIsConsole] = true; - this[kGroupIndent] = ''; }; // Make a function that can serve as the callback passed to `stream.write()`.