Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Share on Twitter Work on Mobile Too #100

Open
danbugs opened this issue Feb 20, 2024 · 0 comments
Open

Make Share on Twitter Work on Mobile Too #100

danbugs opened this issue Feb 20, 2024 · 0 comments
Assignees
Labels
feature new feature good first issue good for people getting started contributing to the project

Comments

@danbugs
Copy link
Owner

danbugs commented Feb 20, 2024

Describe the solution you'd like
Currently, the "Share on Twitter" feature is blocked on mobile because of the way we're currenty screenshotting the DOM w/ html2canvas. If enabled, mobile shares look wonky like:
image

... so it was disabled. To fix this, we'd probably have to make some sort of changes to the CSS to generate smt that works regarless of screen size but is still optimal for a Twitter card.

Additional context
Side note: W/ this, let's also investigate it possibly not working on medium screen sizes. I tried setting the screensize to the iPad Pro option, but I get an error from the image-upload-backend w/:
image

Side note 2: The wonky example was actually captured from my computer w/ an emulation of the phone size. On the phone, for some reason, the image-upload-backend also fails and this probably warrants more investigation too.

@danbugs danbugs added feature new feature good first issue good for people getting started contributing to the project labels Feb 20, 2024
@danbugs danbugs self-assigned this Feb 20, 2024
@danbugs danbugs modified the milestone: Post MVP Feb 20, 2024
@danbugs danbugs assigned danbugs and unassigned danbugs Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature good first issue good for people getting started contributing to the project
Projects
None yet
Development

No branches or pull requests

1 participant