Make cleanliness checks more efficient #15
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 75.79% 75.74% -0.05%
==========================================
Files 15 15
Lines 2549 2544 -5
Branches 563 562 -1
==========================================
- Hits 1932 1927 -5
Misses 458 458
Partials 159 159 ☔ View full report in Codecov by Sentry. |
|
|
||
| return await anyio.to_thread.run_sync(_unclean) | ||
| != "" | ||
| ) |
There was a problem hiding this comment.
I think it would indeed be more efficient but not yet "most efficient" for the case of having heavy changes: would it result in early termination of that git status --porcelain ... on receiving any output, which already would be indicative of being dirty?
There was a problem hiding this comment.
No. I'm not sure if changing the code to terminating git status early would result in git cleaning everything up properly.
There was a problem hiding this comment.
I bet it should be fine since I believe it is typically used as git status --porcelain --untracked-files=normal --ignore-submodules=none | grep -q . which results in similar early closure of the pipe etc.
But anyways -- probably most of our cases are not that heavy on the diff here so would not really be anyhow notably different. Let's proceed.
Closes #14.