-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop injecting "fake" DOIs into draft dandisets #1709
Comments
There's a confluence here with #1710. Perhaps they can be folded into a single issue. |
The other idea here is to split the concepts up, so that our current validation process is meant as a clearinghouse for publishing, and a separate validation process would be for draft dandisets specifically. The latter might be similar to the former, but for certain values being optional, etc. (including, crucially, DOIs). |
this seems very reasonable to me and would also help users who want to insert a doi in their publication for review without it being set in stone if reviewers want changes to the dandiset. and yes it aligns with thoughts in #1710. we can also garbage collect drafts as needed if we see a dandiset abandoned. |
+1 to 'draft DOI' idea; we get this question/request from users very frequently |
I think we could do even better. Similarly to how Zenodo does it, we can have a "dataset DOI" which would first point to draft and then most recent released version. For that reason we do not even need to make it mutable since our DLP shows most released one IIRC. But the only concern is -- metadata which would be absent upon creation and then improved. So we could create DOI with minimal/fake metadata and then keep updating it upon every metadata editing. I bet there is type of mutable DOI we could use here, couldn't we? |
Just pinging this as I found a fake DOI in the wild in https://arxiv.org/pdf/2406.19492
Here are a few more: https://scholar.google.com/scholar?hl=en&as_sdt=0%2C21&q=https%3A%2F%2Fdoi.org%2F10.80507%2Fdandi.+123456%2F0.123456.1234&btnG= |
I strongly believe we should address it via description of which I just updated with more detail. |
so do you think of creating a new class |
I didn't look into how it could/should be implemented but I wouldn't call "Draft" to be "Published" somehow. It is more of a point that even Draft one should acquire ability to have a valid DOI if it doesn't have one yet. |
Our current publish/DOI creation workflow needs improvement. Currently, when publishing a dandiset, we inject a "fake" DOI into the dandiset metadata in order to allow it to be validated against the
PublishedDandiset
schema; this is because we cannot validate a dandiset without putting a valid DOI in its metadata, but we don't want to hit the DOI server for a real DOI without first validating our dandiset.Instead of using a "fake" DOI , we can create a "draft DOI" for all draft dandisets. Then, we can promote those to a "Findable" DOI when a publish actually happens.
The text was updated successfully, but these errors were encountered: