Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop injecting "fake" DOIs into draft dandisets #1709

Open
mvandenburgh opened this issue Oct 16, 2023 · 9 comments
Open

Stop injecting "fake" DOIs into draft dandisets #1709

mvandenburgh opened this issue Oct 16, 2023 · 9 comments
Assignees
Labels
bug Something isn't working DOI

Comments

@mvandenburgh
Copy link
Member

Our current publish/DOI creation workflow needs improvement. Currently, when publishing a dandiset, we inject a "fake" DOI into the dandiset metadata in order to allow it to be validated against the PublishedDandiset schema; this is because we cannot validate a dandiset without putting a valid DOI in its metadata, but we don't want to hit the DOI server for a real DOI without first validating our dandiset.

Instead of using a "fake" DOI , we can create a "draft DOI" for all draft dandisets. Then, we can promote those to a "Findable" DOI when a publish actually happens.

@mvandenburgh mvandenburgh self-assigned this Oct 16, 2023
@waxlamp
Copy link
Member

waxlamp commented Feb 2, 2024

There's a confluence here with #1710. Perhaps they can be folded into a single issue.

@waxlamp
Copy link
Member

waxlamp commented Feb 2, 2024

The other idea here is to split the concepts up, so that our current validation process is meant as a clearinghouse for publishing, and a separate validation process would be for draft dandisets specifically. The latter might be similar to the former, but for certain values being optional, etc. (including, crucially, DOIs).

@waxlamp waxlamp added bug Something isn't working maintenance Action to maintain the system (neither a bugfix nor an enhancement) and removed bug Something isn't working maintenance Action to maintain the system (neither a bugfix nor an enhancement) labels Feb 2, 2024
@satra
Copy link
Member

satra commented Feb 2, 2024

Instead of using a "fake" DOI , we can create a "draft DOI" for all draft dandisets. Then, we can promote those to a "Findable" DOI when a publish actually happens.

this seems very reasonable to me and would also help users who want to insert a doi in their publication for review without it being set in stone if reviewers want changes to the dandiset. and yes it aligns with thoughts in #1710. we can also garbage collect drafts as needed if we see a dandiset abandoned.

@CodyCBakerPhD
Copy link

this seems very reasonable to me and would also help users who want to insert a doi in their publication for review without it being set in stone if reviewers want changes to the dandiset.

+1 to 'draft DOI' idea; we get this question/request from users very frequently

@yarikoptic
Copy link
Member

I think we could do even better. Similarly to how Zenodo does it, we can have a "dataset DOI" which would first point to draft and then most recent released version. For that reason we do not even need to make it mutable since our DLP shows most released one IIRC. But the only concern is -- metadata which would be absent upon creation and then improved. So we could create DOI with minimal/fake metadata and then keep updating it upon every metadata editing. I bet there is type of mutable DOI we could use here, couldn't we?

@rly
Copy link

rly commented Jul 7, 2024

Just pinging this as I found a fake DOI in the wild in https://arxiv.org/pdf/2406.19492

29. Mazzamuto, G. et al. Human brain cell census for ba 44/45 (version draft). DANDI archive https://doi.org/10.80507/dandi.
123456/0.123456.1234 (2004).

Here are a few more: https://scholar.google.com/scholar?hl=en&as_sdt=0%2C21&q=https%3A%2F%2Fdoi.org%2F10.80507%2Fdandi.+123456%2F0.123456.1234&btnG=

@yarikoptic
Copy link
Member

I strongly believe we should address it via

description of which I just updated with more detail.

@djarecka
Copy link
Member

so do you think of creating a new class PublishedDraftDandiset with schema that has the same field as PublishedDandiset, but more fields that are optional?

@yarikoptic
Copy link
Member

I didn't look into how it could/should be implemented but I wouldn't call "Draft" to be "Published" somehow. It is more of a point that even Draft one should acquire ability to have a valid DOI if it doesn't have one yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DOI
Projects
None yet
Development

No branches or pull requests

7 participants