New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock dandiset when changing owner list #2000

Open

waxlamp opened this issue Aug 9, 2024 · 0 comments

Labels

bug

Member

waxlamp commented Aug 9, 2024 •

edited

Loading

Originally posted by @mvandenburgh in #1886 (comment):

This problem existed before this PR, but I'll just mention that by the time this .save() is called this Dandiset object might be stale. I think we need to lock the dandiset object with select_for_update.

dandi-archive/dandiapi/api/views/dandiset.py

Lines 416 to 420 in 0a225f4

    
           # All owners found 
        
           with transaction.atomic(): 
        
               owners = user_owners + [acc.user for acc in socialaccount_owners] 
        
               removed_owners, added_owners = dandiset.set_owners(owners) 
        
               dandiset.save()

The text was updated successfully, but these errors were encountered:

waxlamp added the bug label

waxlamp mentioned this issue

Add audit backend #1886

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment