Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable circle-ci? #4

Closed
yarikoptic opened this issue Sep 17, 2020 · 2 comments
Closed

Enable circle-ci? #4

yarikoptic opened this issue Sep 17, 2020 · 2 comments

Comments

@yarikoptic
Copy link
Member

There is circle-ci setup cloned along.
I bet it is easy, but I never dealt with setting up circle ci for a repo so I would appreciate if someone else (@satra?) would do it so we get PRs and on cron tested here.

@mgrauer
Copy link
Contributor

mgrauer commented Sep 22, 2020

How about we enable Circle-CI for now, until someone sets up github actions? @dchiquit had merged some PRs that didn't lint or pass tests in dandi-api repo, and we don't want to do that in the future. Enabling circle should be very quick as there is already a config file.

What is the reason to move from Circle to GitHub actions @satra (as referenced in #1) ?

I myself don't have a strong preference--as long GitHub actions can give us what we get from circle--other than getting CI setup ASAP and circle is already most of the way there (and our config is debugged) for this repo.

@mgrauer
Copy link
Contributor

mgrauer commented Nov 10, 2020

Circle is running for now. We will update to GitHub Actions at some point.

@mgrauer mgrauer closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants