Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure store variables #694

Closed
mvandenburgh opened this issue Jan 6, 2022 · 1 comment
Closed

Restructure store variables #694

mvandenburgh opened this issue Jan 6, 2022 · 1 comment
Labels
DX Affects developer experience enhancement New feature or request

Comments

@mvandenburgh
Copy link
Member

Accessing the current dandiset from the vuex store requires the following:

store.state.dandiset.dandiset.dandiset

Breakdown of what each property means:

store
state
dandiset => the vuex namespace module
dandiset => the variable in the store that is of type `Version`
dandiset => the `Version.dandiset` property

We may want to consider one or both of the following:

  1. Remove the dandiset vuex module and just make everything top level. We have no other modules so this makes sense to me.
  2. Rename the store variable to version.

Applying both of the above would change the previous statement to store.state.version.dandiset.

@waxlamp waxlamp transferred this issue from dandi/dandiarchive-legacy Jan 13, 2022
@waxlamp waxlamp added DX Affects developer experience enhancement New feature or request labels Jan 13, 2022
@mvandenburgh
Copy link
Member Author

This is no longer relevant now that we've moved from vuex to pinia #1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affects developer experience enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants