From 427d1dc8f7c6189482d072504d3f75e9e0af1d48 Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Tue, 30 Jan 2024 13:19:58 -0500 Subject: [PATCH 1/3] Include tooltips on action icons --- web/src/views/FileBrowserView/FileBrowser.vue | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/src/views/FileBrowserView/FileBrowser.vue b/web/src/views/FileBrowserView/FileBrowser.vue index 70979e351..4d4ae08d2 100644 --- a/web/src/views/FileBrowserView/FileBrowser.vue +++ b/web/src/views/FileBrowserView/FileBrowser.vue @@ -149,6 +149,7 @@ icon :href="inlineURI(item.asset.asset_id)" target="_blank" + title="View asset" > mdi-eye @@ -160,6 +161,7 @@ mdi-download @@ -173,6 +175,7 @@ :href="assetMetadataURI(item.asset.asset_id)" target="_blank" rel="noopener" + title="View asset metadata" > mdi-information @@ -190,6 +193,7 @@ v-if="item.services && item.services.length" color="primary" icon + title="Open in external service" v-bind="attrs" v-on="on" > From dfe015435e394485be7a4698cd836ef0f8750da0 Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Tue, 30 Jan 2024 13:49:19 -0500 Subject: [PATCH 2/3] Use v-tooltip instead of title attribute --- web/src/views/FileBrowserView/FileBrowser.vue | 78 ++++++++++++------- 1 file changed, 48 insertions(+), 30 deletions(-) diff --git a/web/src/views/FileBrowserView/FileBrowser.vue b/web/src/views/FileBrowserView/FileBrowser.vue index 4d4ae08d2..225dbc79d 100644 --- a/web/src/views/FileBrowserView/FileBrowser.vue +++ b/web/src/views/FileBrowserView/FileBrowser.vue @@ -145,42 +145,60 @@ - - - mdi-eye - - + + + View asset in browser + - - - mdi-download - - + + + Download asset + - - - mdi-information - - + + + View asset metadata + From b432a2fd85ed387ae8f3492a27f82d99b640902f Mon Sep 17 00:00:00 2001 From: Roni Choudhury Date: Tue, 30 Jan 2024 14:52:18 -0500 Subject: [PATCH 3/3] Use rel="noreferrer" with target="_blank" links --- web/src/views/FileBrowserView/FileBrowser.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/src/views/FileBrowserView/FileBrowser.vue b/web/src/views/FileBrowserView/FileBrowser.vue index 225dbc79d..4447fb3ad 100644 --- a/web/src/views/FileBrowserView/FileBrowser.vue +++ b/web/src/views/FileBrowserView/FileBrowser.vue @@ -151,6 +151,7 @@ icon :href="inlineURI(item.asset.asset_id)" target="_blank" + rel="noreferrer" v-bind="attrs" v-on="on" > @@ -188,7 +189,7 @@ icon :href="assetMetadataURI(item.asset.asset_id)" target="_blank" - rel="noopener" + rel="noreferrer" v-bind="attrs" v-on="on" > @@ -242,7 +243,7 @@ :key="el.name" :href="el.url" target="_blank" - rel="noopener" + rel="noreferrer" > {{ el.name }}