-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle uploading already-present files in new API #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 82.15% 83.82% +1.66%
==========================================
Files 55 55
Lines 5454 5935 +481
==========================================
+ Hits 4481 4975 +494
+ Misses 973 960 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The PR includes the requested tests, but several of them currently fail (and are marked xfailing) due to #345 (comment) and dandi/dandi-archive#70 not yet being addressed. |
Thank you @jwodder . I guess we are just doomed to wait for dandi/dandi-archive#70 to get implemented (outstanding PR: dandi/dandi-archive#75) |
there is |
Found another blocking bug: dandi/dandi-archive#76 |
dandi/dandi-archive#76 was addressed, so should be possible to proceed forward. |
A new blocking bug: dandi/dandi-archive#81 |
I have just merged dandi/dandi-archive#84 which should provide remedy (even if later to be refactored) so we could proceed here. |
@yarikoptic Tests finally pass. |
awesome -- let's proceed! |
Closes #345.