Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & test for downloading by asset ID URL #561

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix & test for downloading by asset ID URL #561

merged 1 commit into from
Apr 13, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 13, 2021

Fixes #557.

@jwodder jwodder added the patch Increment the patch version when merged label Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #561 (a337060) into master (3ded813) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   83.51%   83.63%   +0.12%     
==========================================
  Files          62       62              
  Lines        6489     6500      +11     
==========================================
+ Hits         5419     5436      +17     
+ Misses       1070     1064       -6     
Flag Coverage Δ
unittests 83.63% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/download.py 88.09% <100.00%> (+1.64%) ⬆️
dandi/tests/test_download.py 100.00% <100.00%> (ø)
dandi/dandiarchive.py 85.31% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ded813...a337060. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you @jwodder ! I think I am now getting to what you meant by different returned records for assets - we might need to harmonize them on the client side, may be as part of the #249 (I hope to get back to that one soon, time to progress it forward)

@yarikoptic yarikoptic merged commit 7a843bd into master Apr 13, 2021
@yarikoptic yarikoptic deleted the gh-557 branch April 13, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with download
2 participants