Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLSX derivative files. #5

Open
TheChymera opened this issue Jul 19, 2022 · 5 comments
Open

XLSX derivative files. #5

TheChymera opened this issue Jul 19, 2022 · 5 comments

Comments

@TheChymera
Copy link

BIDS does not support *.xlsx files.

There are a number of such files in the derivatives:

derivatives/MBF_stereology/sub-I48/sub-I48_sample-BrocaAreaS30_stain-NeuN_loc-Layer6_STER.xlsx
derivatives/MBF_stereology/sub-I48/sub-I48_sample-BrocaAreaS30_stain-NeuN_loc-Layer3_STER.xlsx
...
derivatives/MBF_stereology/sub-I46/sub-I46_sample-BrocaAreaS11_stain-Calretinin_loc-Layer3_STER.xlsx
derivatives/MBF_stereology/sub-I46/sub-I46_sample-BrocaAreaS22_stain-NeuN_loc-Layer3and5_STER.xlsx

Ideally they should be dealt with in one of the following manners:

  • reformatted to .tsv or .json
  • deleted
@satra
Copy link

satra commented Jul 19, 2022

i'm not sure it doesn't support it under derivatives. but indeed should be checked if these could be converted to tsv.

@TheChymera
Copy link
Author

TheChymera commented Jul 19, 2022

The string xlsx is nowhere to be found in the BIDS schema, nor in the whole specification. Perhaps it's implied somewhere, and please correct me if it is.

@satra
Copy link

satra commented Jul 19, 2022

derivatives don't have the same restrictions as "rawdata" for either names or types as far as i know. thus technically you could store anything in any name as long as the pipeline and dataset type for the derived dataset was covered in a dataset_description.json.

see:

for various derivatives standardization is going to take a while, so best practice is going to be more important than invalid. specifically see this section:

@TheChymera
Copy link
Author

ok, I stand corrected. In that case we should either be extra demanding and require BIDS-style derivatives only, or just forego validation for derivatives. This also means that most of my new issues can technically be disregarded, and I should just make sure that the derivatives directory is skipped.

@satra
Copy link

satra commented Jul 19, 2022

i think we should still check the derivative dataset convention (e.g., dataset_description existence and fields). the naming convention is a bit moot at this point but perhaps we could build up warnings for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants