-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support "data:image/gif;base64" #519
Comments
hi @TomySmit , it's already supported as far as I know. See Line 89 in 9343409
https://github.com/danfickle/openhtmltopdf/blob/open-dev-v1/openhtmltopdf-pdfbox/src/main/java/com/openhtmltopdf/pdfboxout/PdfBoxUserAgent.java#L75 which load the base 64 encoded image. |
There may be a problem if base64 string has a space before, e.g.
openhtmltopdf/openhtmltopdf-core/src/main/java/com/openhtmltopdf/swing/NaiveUserAgent.java Line 410 in b98f5b8
data:image/png;base64,iVBORw0... - will render correctly
|
@roman0x58 interesting, I guess that we need to handle the data uri in a more robust way. I'll provide a PR to handle this case :D |
Fixed with PR provided by @syjer. Re-open as required. |
Add support "data:image/gif;base64" like svg in img tag
The text was updated successfully, but these errors were encountered: