Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useless schemas/dtd in openhtmltopdf-core/src/main/resources/resources ? #523

Closed
syjer opened this issue Aug 3, 2020 · 2 comments
Closed

useless schemas/dtd in openhtmltopdf-core/src/main/resources/resources ? #523

syjer opened this issue Aug 3, 2020 · 2 comments

Comments

@syjer
Copy link
Contributor

syjer commented Aug 3, 2020

Hi @danfickle , I've noticed in openhtmltopdf-core/src/main/resources/resources we have some dtd/schema that are not referenced in the project:

  • openhtmltopdf-core/src/main/resources/resources/schema/docbook/
  • openhtmltopdf-core/src/main/resources/resources/schema/html-4.01/
  • openhtmltopdf-core/src/main/resources/resources/schema/xhtml/

Do they have any use? Removing them does not seems to cause any issue in the build/tests.
@danfickle
Copy link
Owner

Yes, I think they are ancient cruft that could be removed.

@syjer
Copy link
Contributor Author

syjer commented Aug 4, 2020

I'll provide a PR then :).

@syjer syjer mentioned this issue Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syjer @danfickle