Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple background images on first page #649

Closed
baedorf opened this issue Feb 11, 2021 · 2 comments
Closed

Multiple background images on first page #649

baedorf opened this issue Feb 11, 2021 · 2 comments
Assignees

Comments

@baedorf
Copy link

baedorf commented Feb 11, 2021

I need to combine/place several images on first page using following css:

@page:first {
    @top-center {
         content: 'first';
     }
     background-image: url(background.png), url(image13.png);
}

According to css this should be valid and allowed.
Creating a PDF produces following message

com.openhtmltopdf.css-parse WARNING:: (f#inline_style_1) Found 2 value(s) for background-image when 1 value(s) were expected at line 52. Skipping declaration.

How to solve this?

danfickle added a commit that referenced this issue Feb 12, 2021
So they can easily be edited to all allow multiple values.
danfickle added a commit that referenced this issue Feb 12, 2021
+ Needs tests.
+ Needs other background propery support such as position and size.
danfickle added a commit that referenced this issue Feb 12, 2021
@danfickle
Copy link
Owner

Multiple background images is a CSS3 feature and isn't supported. However I have started implementing it in #650.

@danfickle danfickle self-assigned this Feb 12, 2021
danfickle added a commit that referenced this issue Feb 14, 2021
danfickle added a commit that referenced this issue Feb 15, 2021
Currently the property is a no-op as the only valid value is scroll.
danfickle added a commit that referenced this issue Feb 16, 2021
This might work if we maintain it.
@danfickle
Copy link
Owner

Thanks @baedorf. Will be released with 1.0.7. Background properties on wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants