Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton tips easily overwritten within the plantcv.morphology sub-package #1643

Open
HaleySchuhl opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1644
Open

Skeleton tips easily overwritten within the plantcv.morphology sub-package #1643

HaleySchuhl opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1644
Labels
help wanted Request help
Milestone

Comments

@HaleySchuhl
Copy link
Contributor

Describe the bug
Skeleton tips are easily overwritten within the plantcv morphology sub-package since utilizing tips happens in a few other functions as part of the algorithm for sorting or pruning back segments.

To Reproduce
Steps to reproduce the behavior (including sample data and code really help):

  1. Starting with image from the morphology tutorial
  2. Run function(s) pcv.morphology.find_tips with label=None and then run pcv.morphology.segment_sort or pcv.morphology.prune
  3. See error (small green are expected tips, large green are the recorded tip coordinates)
    image

Expected behavior
Only save tip coordinates when the function is explicitly ran/

Local environment (please complete the following information):

  • PlantCV Version : <= 4.6.0

Additional context
Making a helper function to be able to call within functions and now pcv.morphology.find_tips will be a function that saves to Outputs.observations and is a wrapper of pcv.morphology._find_tips.

@HaleySchuhl HaleySchuhl added the help wanted Request help label Dec 19, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.6 milestone Dec 19, 2024
@github-project-automation github-project-automation bot moved this to New Issues in PlantCV4 Dec 19, 2024
@HaleySchuhl HaleySchuhl linked a pull request Dec 19, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Request help
Projects
Status: New Issues
Development

Successfully merging a pull request may close this issue.

1 participant